Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing documentation. #177

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Conversation

AureliaDolo
Copy link
Contributor

Fix #153

Hello, here are some bits of doc, and the the warnings.

Thanks!

Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much. That's pretty good! 😊

heed/src/lazy_decode.rs Outdated Show resolved Hide resolved
@AureliaDolo
Copy link
Contributor Author

AureliaDolo commented Jul 6, 2023

The remaining clippy warnings are:

  • safety doc for RwRevIter::append
  • safety doc for Env::copy_to_fd
  • module inception for iter

I'd happily take your suggestions on these !

AureliaDolo and others added 2 commits July 7, 2023 14:03
Co-authored-by: Clément Renault <renault.cle@gmail.com>
@Kerollmops
Copy link
Member

I merge this PR as it looks good to me and I am awaiting the changes in #178 🎉

@Kerollmops Kerollmops merged commit 1f62d00 into meilisearch:main Jul 10, 2023
@Kerollmops Kerollmops added this to the v0.20.0 milestone Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document everything in the heed, heed-types and heed-traits crates
2 participants